Revert of Change base::Value::ListStorage to std::vector<base::Value>

chrome/browser/plugins/plugin_finder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/plugins/plugin_finder.h"
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/json/json_reader.h"
@@ skipping 62 matching lines @@
   const base::ListValue* mime_types = NULL;
   std::string list_key =
       matching_mime_types ? "matching_mime_types" : "mime_types";
   if (!plugin_dict->GetList(list_key, &mime_types))
     return;
 
   bool success = false;
   for (base::ListValue::const_iterator mime_type_it = mime_types->begin();
        mime_type_it != mime_types->end(); ++mime_type_it) {
     std::string mime_type_str;
-    success = mime_type_it->GetAsString(&mime_type_str);
+    success = (*mime_type_it)->GetAsString(&mime_type_str);
     DCHECK(success);
     if (matching_mime_types) {
       plugin->AddMatchingMimeType(mime_type_str);
     } else {
       plugin->AddMimeType(mime_type_str);
     }
   }
 }
 
 std::unique_ptr<PluginMetadata> CreatePluginMetadata(
@@ skipping 14 matching lines @@
   std::string language_str;
   plugin_dict->GetString("lang", &language_str);
 
   std::unique_ptr<PluginMetadata> plugin = base::MakeUnique<PluginMetadata>(
       identifier, name, display_url, GURL(url), GURL(help_url),
       group_name_matcher, language_str);
   const base::ListValue* versions = NULL;
   if (plugin_dict->GetList("versions", &versions)) {
     for (base::ListValue::const_iterator it = versions->begin();
          it != versions->end(); ++it) {
-      const base::DictionaryValue* version_dict = NULL;
-      if (!it->GetAsDictionary(&version_dict)) {
+      base::DictionaryValue* version_dict = NULL;
+      if (!(*it)->GetAsDictionary(&version_dict)) {
         NOTREACHED();
         continue;
       }
       std::string version;
       success = version_dict->GetString("version", &version);
       DCHECK(success);
       std::string status_str;
       success = version_dict->GetString("status", &status_str);
       DCHECK(success);
       PluginMetadata::SecurityStatus status =
@@ skipping 198 matching lines @@
     metadata->AddMatchingMimeType(plugin.mime_types[i].mime_type);
 
   DCHECK(metadata->MatchesPlugin(plugin));
   if (identifier_plugin_.find(identifier) != identifier_plugin_.end())
     identifier = GetLongIdentifier(plugin);
 
   DCHECK(identifier_plugin_.find(identifier) == identifier_plugin_.end());
   identifier_plugin_[identifier] = std::move(metadata);
   return identifier_plugin_[identifier]->Clone();
 }