Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7551)

Unified Diff: chromeos/network/onc/onc_validator.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/onc/onc_utils_unittest.cc ('k') | chromeos/network/policy_applicator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_validator.cc
diff --git a/chromeos/network/onc/onc_validator.cc b/chromeos/network/onc/onc_validator.cc
index 97150fdae6123975364b8ec8faf4fc9d42aac43f..d4286205ed19548198a7f319ab7debdb62a863ec 100644
--- a/chromeos/network/onc/onc_validator.cc
+++ b/chromeos/network/onc/onc_validator.cc
@@ -245,7 +245,7 @@
std::unique_ptr<base::ListValue> repaired_recommended(new base::ListValue);
for (const auto& entry : *recommended_list) {
std::string field_name;
- if (!entry.GetAsString(&field_name)) {
+ if (!entry->GetAsString(&field_name)) {
NOTREACHED(); // The types of field values are already verified.
continue;
}
@@ -404,7 +404,7 @@
path_.push_back(field_name);
for (const auto& entry : *list) {
std::string value;
- if (!entry.GetAsString(&value)) {
+ if (!entry->GetAsString(&value)) {
NOTREACHED(); // The types of field values are already verified.
continue;
}
« no previous file with comments | « chromeos/network/onc/onc_utils_unittest.cc ('k') | chromeos/network/policy_applicator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698