Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: content/browser/webrtc/webrtc_internals_unittest.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/webrtc/webrtc_internals.cc ('k') | content/renderer/gpu/actions_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/webrtc/webrtc_internals_unittest.cc
diff --git a/content/browser/webrtc/webrtc_internals_unittest.cc b/content/browser/webrtc/webrtc_internals_unittest.cc
index bdadf0a0b5c2167a53b60842aef2c2c88242592a..d14eef08e32dd232d3a274b68ceef34bfe31ce57 100644
--- a/content/browser/webrtc/webrtc_internals_unittest.cc
+++ b/content/browser/webrtc/webrtc_internals_unittest.cc
@@ -141,7 +141,7 @@
ASSERT_TRUE(observer.value()->GetAsList(&list));
EXPECT_EQ(1U, list->GetSize());
base::DictionaryValue* dict = nullptr;
- ASSERT_TRUE((*list->begin()).GetAsDictionary(&dict));
+ ASSERT_TRUE((*list->begin())->GetAsDictionary(&dict));
base::ListValue* log = nullptr;
ASSERT_FALSE(dict->GetList("log", &log));
@@ -167,7 +167,7 @@
ASSERT_TRUE(observer.value()->GetAsList(&list));
EXPECT_EQ(1U, list->GetSize());
base::DictionaryValue* dict = nullptr;
- ASSERT_TRUE((*list->begin()).GetAsDictionary(&dict));
+ ASSERT_TRUE((*list->begin())->GetAsDictionary(&dict));
base::ListValue* log = nullptr;
ASSERT_TRUE(dict->GetList("log", &log));
@@ -178,7 +178,7 @@
ASSERT_TRUE(observer.value()->GetAsList(&list));
EXPECT_EQ(1U, list->GetSize());
- ASSERT_TRUE((*list->begin()).GetAsDictionary(&dict));
+ ASSERT_TRUE((*list->begin())->GetAsDictionary(&dict));
ASSERT_FALSE(dict->GetList("log", &log));
webrtc_internals.OnRemovePeerConnection(3, 4);
@@ -332,7 +332,7 @@
EXPECT_EQ(1U, list->GetSize());
base::DictionaryValue* dict = NULL;
- EXPECT_TRUE((*list->begin()).GetAsDictionary(&dict));
+ EXPECT_TRUE((*list->begin())->GetAsDictionary(&dict));
VerifyInt(dict, "rid", rid);
VerifyInt(dict, "pid", pid);
@@ -345,7 +345,7 @@
ASSERT_TRUE(dict->GetList("log", &log));
EXPECT_EQ(1U, log->GetSize());
- EXPECT_TRUE((*log->begin()).GetAsDictionary(&dict));
+ EXPECT_TRUE((*log->begin())->GetAsDictionary(&dict));
VerifyString(dict, "type", update_type);
VerifyString(dict, "value", update_value);
std::string time;
« no previous file with comments | « content/browser/webrtc/webrtc_internals.cc ('k') | content/renderer/gpu/actions_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698