Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: ui/display/manager/json_converter.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/app_list/search/history_data_store.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/display/manager/json_converter.cc
diff --git a/ui/display/manager/json_converter.cc b/ui/display/manager/json_converter.cc
index 2520d1d68388862b9b950127a42bad2380da0f4d..213f7e404932a4bfa50806cc016557b52ab4e41d 100644
--- a/ui/display/manager/json_converter.cc
+++ b/ui/display/manager/json_converter.cc
@@ -125,7 +125,7 @@
output->reserve(list->GetSize());
for (const auto& list_item : *list) {
const base::DictionaryValue* item_values = nullptr;
- if (!list_item.GetAsDictionary(&item_values))
+ if (!list_item->GetAsDictionary(&item_values))
return false;
DisplayPlacement item;
« no previous file with comments | « ui/app_list/search/history_data_store.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698