components/flags_ui/pref_service_flags_storage.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/flags_ui/pref_service_flags_storage.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/flags_ui/pref_service_flags_storage.cc

diff --git a/components/flags_ui/pref_service_flags_storage.cc b/components/flags_ui/pref_service_flags_storage.cc

index 2153c1bf6be86fec1366aada2682dd99abbe25be..3c6ddc4dd778abad2c0f0c7e889ec272ce799c0c 100644

--- a/components/flags_ui/pref_service_flags_storage.cc

+++ b/components/flags_ui/pref_service_flags_storage.cc

@@ -26,7 +26,7 @@

for (base::ListValue::const_iterator it = enabled_experiments->begin();

it != enabled_experiments->end(); ++it) {

std::string experiment_name;

- if (!it->GetAsString(&experiment_name)) {

+ if (!(*it)->GetAsString(&experiment_name)) {

LOG(WARNING) << "Invalid entry in " << prefs::kEnabledLabsExperiments;

continue;

}