Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Unified Diff: chrome/browser/ui/webui/options/certificate_manager_handler.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/certificate_manager_handler.cc
diff --git a/chrome/browser/ui/webui/options/certificate_manager_handler.cc b/chrome/browser/ui/webui/options/certificate_manager_handler.cc
index e4c42f4fd52a246abfdba99ecde8fffec73e573c..cce634b34b878f725ed1bc70fff8ac46360d8e0a 100644
--- a/chrome/browser/ui/webui/options/certificate_manager_handler.cc
+++ b/chrome/browser/ui/webui/options/certificate_manager_handler.cc
@@ -88,12 +88,13 @@
: collator_(collator) {
}
- bool operator()(const base::Value& a, const base::Value& b) const {
+ bool operator()(const std::unique_ptr<base::Value>& a,
+ const std::unique_ptr<base::Value>& b) const {
const base::DictionaryValue* a_dict;
- bool a_is_dictionary = a.GetAsDictionary(&a_dict);
+ bool a_is_dictionary = a->GetAsDictionary(&a_dict);
DCHECK(a_is_dictionary);
const base::DictionaryValue* b_dict;
- bool b_is_dictionary = b.GetAsDictionary(&b_dict);
+ bool b_is_dictionary = b->GetAsDictionary(&b_dict);
DCHECK(b_is_dictionary);
base::string16 a_str;
base::string16 b_str;

Powered by Google App Engine
This is Rietveld 408576698