chromeos/dbus/shill_client_helper.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_client_helper.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/shill_client_helper.cc

diff --git a/chromeos/dbus/shill_client_helper.cc b/chromeos/dbus/shill_client_helper.cc

index fbff20821739123542987e093454c7a2de9665ca..46ba9b5b8f5b26d72fe66154099b5f1ba1200f21 100644

--- a/chromeos/dbus/shill_client_helper.cc

+++ b/chromeos/dbus/shill_client_helper.cc

@@ -465,7 +465,7 @@

variant_writer.OpenArray("s", &array_writer);

for (base::ListValue::const_iterator it = list->begin();

it != list->end(); ++it) {

- const base::Value& value = *it;

+ const base::Value& value = **it;

std::string value_string;

if (!value.GetAsString(&value_string))

NET_LOG(ERROR) << "List value not a string: " << value;

« no previous file with comments | « chromeos/dbus/fake_shill_manager_client.cc ('k') | chromeos/dbus/shill_ipconfig_client.cc » ('j') | no next file with comments »