Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5500)

Unified Diff: chrome/common/extensions/api/extension_action/action_info.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_action/action_info.cc
diff --git a/chrome/common/extensions/api/extension_action/action_info.cc b/chrome/common/extensions/api/extension_action/action_info.cc
index c30141df4dfe67ef30e815221603c18dab25e46a..aa8376b06dcbc5477ccb6eab2b38be688afa1717 100644
--- a/chrome/common/extensions/api/extension_action/action_info.cc
+++ b/chrome/common/extensions/api/extension_action/action_info.cc
@@ -68,7 +68,8 @@
dict->GetList(keys::kPageActionIcons, &icons)) {
base::ListValue::const_iterator iter = icons->begin();
std::string path;
- if (iter == icons->end() || !iter->GetAsString(&path) ||
+ if (iter == icons->end() ||
+ !(*iter)->GetAsString(&path) ||
!manifest_handler_helpers::NormalizeAndValidatePath(&path)) {
*error = base::ASCIIToUTF16(errors::kInvalidPageActionIconPath);
return std::unique_ptr<ActionInfo>();

Powered by Google App Engine
This is Rietveld 408576698