Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: components/ntp_snippets/category_rankers/click_based_category_ranker.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/category_rankers/click_based_category_ranker.cc
diff --git a/components/ntp_snippets/category_rankers/click_based_category_ranker.cc b/components/ntp_snippets/category_rankers/click_based_category_ranker.cc
index 31bf8ae6c60ecee45f9846c57a5afcc106154805..4b4cfa964b72e0f89b06cf7c5d3d5e400e31bf1a 100644
--- a/components/ntp_snippets/category_rankers/click_based_category_ranker.cc
+++ b/components/ntp_snippets/category_rankers/click_based_category_ranker.cc
@@ -413,9 +413,9 @@
return false;
}
- for (const base::Value& value : *list) {
- const base::DictionaryValue* dictionary;
- if (!value.GetAsDictionary(&dictionary)) {
+ for (const std::unique_ptr<base::Value>& value : *list) {
+ base::DictionaryValue* dictionary;
+ if (!value->GetAsDictionary(&dictionary)) {
LOG(DFATAL) << "Failed to parse category data from prefs param "
<< prefs::kClickBasedCategoryRankerOrderWithClicks
<< " into dictionary.";
« no previous file with comments | « components/flags_ui/pref_service_flags_storage.cc ('k') | components/ntp_snippets/content_suggestions_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698