extensions/browser/api/storage/storage_api.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/storage/storage_api.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/storage/storage_api.cc

diff --git a/extensions/browser/api/storage/storage_api.cc b/extensions/browser/api/storage/storage_api.cc

index a844b4bbb64641df4f71945f3b98b2e8d0bead56..e6403a31de7ef2c774c30a5d2f94247d4d2c45e1 100644

--- a/extensions/browser/api/storage/storage_api.cc

+++ b/extensions/browser/api/storage/storage_api.cc

@@ -108,7 +108,7 @@

std::string as_string;

for (base::ListValue::const_iterator it = from.begin();

it != from.end(); ++it) {

- if (it->GetAsString(&as_string)) {

+ if ((*it)->GetAsString(&as_string)) {

to->push_back(as_string);

}