chromeos/network/onc/onc_translator_shill_to_onc.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_translator_shill_to_onc.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_translator_shill_to_onc.cc

diff --git a/chromeos/network/onc/onc_translator_shill_to_onc.cc b/chromeos/network/onc/onc_translator_shill_to_onc.cc

index 7796c2afcbd8b6844e21718cede425c699a1dcd9..eacb2c3763fa6c645dedd9b5c206079c34521371 100644

--- a/chromeos/network/onc/onc_translator_shill_to_onc.cc

+++ b/chromeos/network/onc/onc_translator_shill_to_onc.cc

@@ -683,7 +683,7 @@

for (base::ListValue::const_iterator it = list.begin(); it != list.end();

++it) {

const base::DictionaryValue* shill_value = NULL;

- if (!it->GetAsDictionary(&shill_value))

+ if (!(*it)->GetAsDictionary(&shill_value))

continue;

ShillToONCTranslator nested_translator(

*shill_value, onc_source_,

« no previous file with comments | « chromeos/network/onc/onc_merger.cc ('k') | chromeos/network/onc/onc_utils.cc » ('j') | no next file with comments »