Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3991)

Unified Diff: chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc
diff --git a/chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc b/chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc
index f628eb5e8cdf48b9d57c5dab6ce8e5f5374a44b1..0aea7cbca4dc7b22f425a29ece978bf694e576b9 100644
--- a/chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc
+++ b/chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc
@@ -147,7 +147,7 @@
base::MakeUnique<base::ListValue>());
for (const auto& entry : certificates) {
const base::DictionaryValue* certificate = nullptr;
- if (!entry.GetAsDictionary(&certificate)) {
+ if (!entry->GetAsDictionary(&certificate)) {
DLOG(FATAL) << "Value of a certificate entry is not a dictionary "
<< "value.";
continue;
@@ -168,7 +168,7 @@
bool web_trust_flag = false;
for (const auto& list_val : *trust_list) {
std::string trust_type;
- if (!list_val.GetAsString(&trust_type))
+ if (!list_val->GetAsString(&trust_type))
NOTREACHED();
if (trust_type == ::onc::certificate::kWeb) {

Powered by Google App Engine
This is Rietveld 408576698