Revert of Change base::Value::ListStorage to std::vector<base::Value>

ios/chrome/browser/autofill/autofill_agent.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/autofill/autofill_agent.h"
 
 #include <memory>
 #include <string>
 
 #include "base/format_macros.h"
@@ skipping 249 matching lines @@
     fieldData->role = autofill::AutofillField::ROLE_ATTRIBUTE_PRESENTATION;
   }
 
   // TODO(crbug.com/427614): Extract |text_direction|.
 
   // Load option values where present.
   const base::ListValue* optionValues;
   if (field.GetList("option_values", &optionValues)) {
     for (const auto& optionValue : *optionValues) {
       base::string16 value;
-      if (optionValue.GetAsString(&value))
+      if (optionValue->GetAsString(&value))
         fieldData->option_values.push_back(value);
     }
   }
 
   // Load option contents where present.
   const base::ListValue* optionContents;
   if (field.GetList("option_contents", &optionContents)) {
     for (const auto& optionContent : *optionContents) {
       base::string16 content;
-      if (optionContent.GetAsString(&content))
+      if (optionContent->GetAsString(&content))
         fieldData->option_contents.push_back(content);
     }
   }
 
   if (fieldData->option_values.size() != fieldData->option_contents.size())
     return NO;  // Option values and contents lists should match 1-1.
 
   return YES;
 }
 
@@ skipping 67 matching lines @@
   // Get the list of forms.
   const base::ListValue* formsList;
   if (!data->GetList("forms", &formsList))
     return NO;
 
   // Iterate through all the extracted forms and copy the data from JSON into
   // AutofillManager structures.
   for (const auto& formDict : *formsList) {
     // Each form list entry should be a JSON dictionary.
     const base::DictionaryValue* formData;
-    if (!formDict.GetAsDictionary(&formData))
+    if (!formDict->GetAsDictionary(&formData))
       return NO;
 
     // Form data is copied into a FormData object field-by-field.
     autofill::FormData form;
     if (!formData->GetString("name", &form.name))
       return NO;
     if (!formName.empty() && formName != form.name)
       continue;
 
     // Origin is mandatory.
@@ skipping 18 matching lines @@
     if (formData->GetBoolean("is_form_tag", &is_form_tag))
       form.is_form_tag = is_form_tag;
 
     // Field list (mandatory) is extracted.
     const base::ListValue* fieldsList;
     if (!formData->GetList("fields", &fieldsList))
       return NO;
     for (const auto& fieldDict : *fieldsList) {
       const base::DictionaryValue* field;
       autofill::FormFieldData fieldData;
-      if (fieldDict.GetAsDictionary(&field) &&
+      if (fieldDict->GetAsDictionary(&field) &&
           [self extractFormField:*field asFieldData:&fieldData]) {
         form.fields.push_back(fieldData);
       } else {
         return NO;
       }
     }
     formsData->push_back(form);
   }
   return YES;
 }
@@ skipping 442 matching lines @@
     }
     predictionData.SetWithoutPathExpansion(base::UTF16ToUTF8(formData.name),
                                            formJSONData);
   }
   std::string dataString;
   base::JSONWriter::Write(predictionData, &dataString);
   [jsAutofillManager_ fillPredictionData:base::SysUTF8ToNSString(dataString)];
 }
 
 @end