Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: chrome/browser/plugins/plugin_finder_unittest.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugins/plugin_finder.cc ('k') | chrome/browser/plugins/plugin_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/plugin_finder_unittest.cc
diff --git a/chrome/browser/plugins/plugin_finder_unittest.cc b/chrome/browser/plugins/plugin_finder_unittest.cc
index d906f06f292c1f6256cab330fe971be2824c6288..4cb60f83beb513a1adb35d9865e8eb80dde43779 100644
--- a/chrome/browser/plugins/plugin_finder_unittest.cc
+++ b/chrome/browser/plugins/plugin_finder_unittest.cc
@@ -43,7 +43,7 @@
if (plugin->GetList("mime_types", &mime_types)) {
for (base::ListValue::const_iterator mime_type_it = mime_types->begin();
mime_type_it != mime_types->end(); ++mime_type_it) {
- EXPECT_TRUE(mime_type_it->GetAsString(&dummy_str));
+ EXPECT_TRUE((*mime_type_it)->GetAsString(&dummy_str));
}
}
@@ -51,7 +51,7 @@
if (plugin->GetList("matching_mime_types", &matching_mime_types)) {
for (base::ListValue::const_iterator it = matching_mime_types->begin();
it != matching_mime_types->end(); ++it) {
- EXPECT_TRUE(it->GetAsString(&dummy_str));
+ EXPECT_TRUE((*it)->GetAsString(&dummy_str));
}
}
@@ -61,8 +61,8 @@
for (base::ListValue::const_iterator it = versions->begin();
it != versions->end(); ++it) {
- const base::DictionaryValue* version_dict = NULL;
- ASSERT_TRUE(it->GetAsDictionary(&version_dict));
+ base::DictionaryValue* version_dict = NULL;
+ ASSERT_TRUE((*it)->GetAsDictionary(&version_dict));
EXPECT_TRUE(version_dict->GetString("version", &dummy_str));
std::string status_str;
EXPECT_TRUE(version_dict->GetString("status", &status_str));
« no previous file with comments | « chrome/browser/plugins/plugin_finder.cc ('k') | chrome/browser/plugins/plugin_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698