Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: google_apis/gaia/gaia_auth_fetcher.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/dispatcher.cc ('k') | headless/public/internal/value_conversions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "google_apis/gaia/gaia_auth_fetcher.h" 5 #include "google_apis/gaia/gaia_auth_fetcher.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 492
493 base::ListValue* sessionsList; 493 base::ListValue* sessionsList;
494 if (!dict->GetList("sessions", &sessionsList)) 494 if (!dict->GetList("sessions", &sessionsList))
495 return false; 495 return false;
496 496
497 // Find the first login_hint present in any session. 497 // Find the first login_hint present in any session.
498 for (base::ListValue::iterator iter = sessionsList->begin(); 498 for (base::ListValue::iterator iter = sessionsList->begin();
499 iter != sessionsList->end(); 499 iter != sessionsList->end();
500 iter++) { 500 iter++) {
501 base::DictionaryValue* sessionDictionary; 501 base::DictionaryValue* sessionDictionary;
502 if (!iter->GetAsDictionary(&sessionDictionary)) 502 if (!(*iter)->GetAsDictionary(&sessionDictionary))
503 continue; 503 continue;
504 504
505 if (sessionDictionary->GetString("login_hint", login_hint)) 505 if (sessionDictionary->GetString("login_hint", login_hint))
506 break; 506 break;
507 } 507 }
508 508
509 if (login_hint->empty()) 509 if (login_hint->empty())
510 return false; 510 return false;
511 return true; 511 return true;
512 } 512 }
(...skipping 502 matching lines...) Expand 10 before | Expand all | Expand 10 after
1015 return alleged_error.find(kSecondFactor) != 1015 return alleged_error.find(kSecondFactor) !=
1016 std::string::npos; 1016 std::string::npos;
1017 } 1017 }
1018 1018
1019 // static 1019 // static
1020 bool GaiaAuthFetcher::IsWebLoginRequiredSuccess( 1020 bool GaiaAuthFetcher::IsWebLoginRequiredSuccess(
1021 const std::string& alleged_error) { 1021 const std::string& alleged_error) {
1022 return alleged_error.find(kWebLoginRequired) != 1022 return alleged_error.find(kWebLoginRequired) !=
1023 std::string::npos; 1023 std::string::npos;
1024 } 1024 }
OLDNEW
« no previous file with comments | « extensions/renderer/dispatcher.cc ('k') | headless/public/internal/value_conversions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698