chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc ('k') | chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc

diff --git a/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc b/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc

index f912b3500f6c11f589cb3190999fd95c3215c322..affc58b8f2755999ed826ca0614aa9c3f0724b0e 100644

--- a/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc

+++ b/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc

@@ -132,7 +132,7 @@

for (base::ListValue::const_iterator it = list->begin(); it != list->end();

++it) {

std::string locale;

- if (!it->GetAsString(&locale)) {

+ if (!(*it)->GetAsString(&locale)) {

NOTREACHED();

new_recommended_locales.clear();

break;