Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: chrome/browser/extensions/install_signer.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/install_signer.h" 5 #include "chrome/browser/extensions/install_signer.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 bool GetExtensionIdSet(const base::DictionaryValue& dictionary, 139 bool GetExtensionIdSet(const base::DictionaryValue& dictionary,
140 const char* key, 140 const char* key,
141 ExtensionIdSet* ids) { 141 ExtensionIdSet* ids) {
142 const base::ListValue* id_list = NULL; 142 const base::ListValue* id_list = NULL;
143 if (!dictionary.GetList(key, &id_list)) 143 if (!dictionary.GetList(key, &id_list))
144 return false; 144 return false;
145 for (base::ListValue::const_iterator i = id_list->begin(); 145 for (base::ListValue::const_iterator i = id_list->begin();
146 i != id_list->end(); 146 i != id_list->end();
147 ++i) { 147 ++i) {
148 std::string id; 148 std::string id;
149 if (!i->GetAsString(&id)) { 149 if (!(*i)->GetAsString(&id)) {
150 return false; 150 return false;
151 } 151 }
152 ids->insert(id); 152 ids->insert(id);
153 } 153 }
154 return true; 154 return true;
155 } 155 }
156 156
157 } // namespace 157 } // namespace
158 158
159 namespace extensions { 159 namespace extensions {
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
506 if (!verified) 506 if (!verified)
507 result.reset(); 507 result.reset();
508 } 508 }
509 509
510 if (!callback_.is_null()) 510 if (!callback_.is_null())
511 callback_.Run(std::move(result)); 511 callback_.Run(std::move(result));
512 } 512 }
513 513
514 514
515 } // namespace extensions 515 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_web_ui.cc ('k') | chrome/browser/extensions/menu_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698