Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2397)

Unified Diff: chrome/browser/ui/webui/browsing_history_handler.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/browsing_history_handler.cc
diff --git a/chrome/browser/ui/webui/browsing_history_handler.cc b/chrome/browser/ui/webui/browsing_history_handler.cc
index 046516dc3d9d394760e4ae1f529e8689b43ab747..87b3e8d3a90db96a37f5c5243d99b03c70f6fe77 100644
--- a/chrome/browser/ui/webui/browsing_history_handler.cc
+++ b/chrome/browser/ui/webui/browsing_history_handler.cc
@@ -364,13 +364,14 @@
items_to_remove.reserve(args->GetSize());
for (base::ListValue::const_iterator it = args->begin();
it != args->end(); ++it) {
- const base::DictionaryValue* deletion = NULL;
+ base::DictionaryValue* deletion = NULL;
base::string16 url;
- const base::ListValue* timestamps = NULL;
+ base::ListValue* timestamps = NULL;
// Each argument is a dictionary with properties "url" and "timestamps".
- if (!(it->GetAsDictionary(&deletion) && deletion->GetString("url", &url) &&
- deletion->GetList("timestamps", &timestamps))) {
+ if (!((*it)->GetAsDictionary(&deletion) &&
+ deletion->GetString("url", &url) &&
+ deletion->GetList("timestamps", &timestamps))) {
NOTREACHED() << "Unable to extract arguments";
return;
}
@@ -383,7 +384,7 @@
double timestamp;
for (base::ListValue::const_iterator ts_iterator = timestamps->begin();
ts_iterator != timestamps->end(); ++ts_iterator) {
- if (!ts_iterator->GetAsDouble(&timestamp)) {
+ if (!(*ts_iterator)->GetAsDouble(&timestamp)) {
NOTREACHED() << "Unable to extract visit timestamp.";
continue;
}
« no previous file with comments | « chrome/browser/ui/app_list/search/webstore/webstore_provider.cc ('k') | chrome/browser/ui/webui/certificate_viewer_webui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698