components/url_matcher/url_matcher_factory.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/url_matcher/url_matcher_factory.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/url_matcher/url_matcher_factory.cc

diff --git a/components/url_matcher/url_matcher_factory.cc b/components/url_matcher/url_matcher_factory.cc

index 253d022ece1f9e1cb1965a2e2a0c671bf2cdc081..0a30497d94e9b7249252db9a49d96b77c3746daa 100644

--- a/components/url_matcher/url_matcher_factory.cc

+++ b/components/url_matcher/url_matcher_factory.cc

@@ -250,10 +250,10 @@

for (const auto& entry : *value_list) {

int port = 0;

- const base::ListValue* range = NULL;

- if (entry.GetAsInteger(&port)) {

+ base::ListValue* range = NULL;

+ if (entry->GetAsInteger(&port)) {

ranges.push_back(URLMatcherPortFilter::CreateRange(port));

- } else if (entry.GetAsList(&range)) {

+ } else if (entry->GetAsList(&range)) {

int from = 0, to = 0;

if (range->GetSize() != 2u ||

!range->GetInteger(0, &from) ||