Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Unified Diff: chrome/browser/extensions/api/identity/identity_apitest.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/identity/identity_apitest.cc
diff --git a/chrome/browser/extensions/api/identity/identity_apitest.cc b/chrome/browser/extensions/api/identity/identity_apitest.cc
index db214edbb9e2bde65032025c11c1b494172f0a31..d21fdb86ff3fef28ff1f11c6c7197f59b1c84a4b 100644
--- a/chrome/browser/extensions/api/identity/identity_apitest.cc
+++ b/chrome/browser/extensions/api/identity/identity_apitest.cc
@@ -422,7 +422,7 @@
it != results->end();
++it) {
std::unique_ptr<api::identity::AccountInfo> info =
- api::identity::AccountInfo::FromValue(*it);
+ api::identity::AccountInfo::FromValue(**it);
if (info.get())
result_ids.insert(info->id);
else
@@ -454,11 +454,11 @@
} else {
for (const auto& result : *results) {
std::unique_ptr<api::identity::AccountInfo> info =
- api::identity::AccountInfo::FromValue(result);
+ api::identity::AccountInfo::FromValue(*result);
if (info.get())
msg << info->id << " ";
else
- msg << result << "<-" << result.GetType() << " ";
+ msg << *result << "<-" << result->GetType() << " ";
}
}

Powered by Google App Engine
This is Rietveld 408576698