Revert of Change base::Value::ListStorage to std::vector<base::Value>

remoting/protocol/http_ice_config_request.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/http_ice_config_request.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/json/json_reader.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 144 matching lines @@
     ice_config.expiration_time = base::Time::Now();
   } else {
     ice_config.expiration_time =
         base::Time::Now() + lifetime -
         base::TimeDelta::FromSeconds(kMinimumConfigLifetimeSeconds);
   }
 
   // Parse iceServers list and store them in |ice_config|.
   bool errors_found = false;
   for (const auto& server : *ice_servers_list) {
-    const base::DictionaryValue* server_dict;
-    if (!server.GetAsDictionary(&server_dict)) {
+    base::DictionaryValue* server_dict;
+    if (!server->GetAsDictionary(&server_dict)) {
       errors_found = true;
       continue;
     }
 
-    const base::ListValue* urls_list = nullptr;
+    base::ListValue* urls_list = nullptr;
     if (!server_dict->GetList("urls", &urls_list)) {
       errors_found = true;
       continue;
     }
 
     std::string username;
     server_dict->GetString("username", &username);
 
     std::string password;
     server_dict->GetString("credential", &password);
 
     for (const auto& url : *urls_list) {
       std::string url_str;
-      if (!url.GetAsString(&url_str)) {
+      if (!url->GetAsString(&url_str)) {
         errors_found = true;
         continue;
       }
       if (!AddServerToConfig(url_str, username, password, &ice_config)) {
         LOG(ERROR) << "Invalid ICE server URL: " << url_str;
       }
     }
   }
 
   if (errors_found) {
     LOG(ERROR) << "Received ICE config from the server that contained errors: "
                << result.response_body;
   }
 
   // If there are no STUN or no TURN servers then mark the config as expired so
   // it will refreshed for the next session.
   if (errors_found || ice_config.stun_servers.empty() ||
       ice_config.turn_servers.empty()) {
     ice_config.expiration_time = base::Time::Now();
   }
 
   base::ResetAndReturn(&on_ice_config_callback_).Run(ice_config);
 }
 
 }  // namespace protocol
 }  // namespace remoting