Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: content/browser/android/java/gin_java_method_invocation_helper.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/java/gin_java_method_invocation_helper.cc
diff --git a/content/browser/android/java/gin_java_method_invocation_helper.cc b/content/browser/android/java/gin_java_method_invocation_helper.cc
index 1a5d1df6a06cf321e757f6f13ade1f8750699bf7..b4a3013e8e1527d023889aca8ec961033a2c59b7 100644
--- a/content/browser/android/java/gin_java_method_invocation_helper.cc
+++ b/content/browser/android/java/gin_java_method_invocation_helper.cc
@@ -57,12 +57,12 @@
const base::ListValue* list;
list_value.GetAsList(&list);
for (const auto& entry : *list) {
- if (AppendObjectRef(dispatcher, entry))
+ if (AppendObjectRef(dispatcher, *entry))
continue;
- if (entry.IsType(base::Value::Type::LIST)) {
- BuildObjectRefsFromListValue(dispatcher, entry);
- } else if (entry.IsType(base::Value::Type::DICTIONARY)) {
- BuildObjectRefsFromDictionaryValue(dispatcher, entry);
+ if (entry->IsType(base::Value::Type::LIST)) {
+ BuildObjectRefsFromListValue(dispatcher, *entry);
+ } else if (entry->IsType(base::Value::Type::DICTIONARY)) {
+ BuildObjectRefsFromDictionaryValue(dispatcher, *entry);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698