Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: chrome/browser/android/vr_shell/gltf_parser.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/gltf_parser.cc
diff --git a/chrome/browser/android/vr_shell/gltf_parser.cc b/chrome/browser/android/vr_shell/gltf_parser.cc
index 6dbde77ac9e81adbab0a662e92cc178073a9c0f0..b8f5bd7ec6296698448dafda41a5ecdc0c663f61 100644
--- a/chrome/browser/android/vr_shell/gltf_parser.cc
+++ b/chrome/browser/android/vr_shell/gltf_parser.cc
@@ -206,7 +206,7 @@
if (mesh_dict->GetList("primitives", &list)) {
for (const auto& primitive_value : *list) {
const base::DictionaryValue* primitive_dict;
- if (!primitive_value.GetAsDictionary(&primitive_dict))
+ if (!primitive_value->GetAsDictionary(&primitive_dict))
return false;
auto primitive = ProcessPrimitive(*primitive_dict);
@@ -261,7 +261,7 @@
if (node_dict->GetList("meshes", &list)) {
std::string mesh_key;
for (const auto& mesh_value : *list) {
- if (!mesh_value.GetAsString(&mesh_key))
+ if (!mesh_value->GetAsString(&mesh_key))
return false;
auto mesh_it = mesh_ids_.find(mesh_key);
if (mesh_it == mesh_ids_.end())
@@ -284,7 +284,7 @@
if (node_dict->GetList("children", &list)) {
std::string node_key;
for (const auto& mesh_value : *list) {
- if (!mesh_value.GetAsString(&node_key))
+ if (!mesh_value->GetAsString(&node_key))
return false;
auto node_it = nodes.find(node_key);
if (node_it == nodes.end())
@@ -308,7 +308,7 @@
if (scene_dict->GetList("nodes", &list)) {
std::string node_key;
for (const auto& node_value : *list) {
- if (!node_value.GetAsString(&node_key))
+ if (!node_value->GetAsString(&node_key))
return false;
auto node_it = node_ids_.find(node_key);
if (node_it == node_ids_.end())
« no previous file with comments | « chrome/browser/android/bookmarks/partner_bookmarks_shim.cc ('k') | chrome/browser/android/vr_shell/ui_scene.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698