Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: chrome/test/chromedriver/performance_logger.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/logging.cc ('k') | chrome/utility/importer/nss_decryptor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/performance_logger.cc
diff --git a/chrome/test/chromedriver/performance_logger.cc b/chrome/test/chromedriver/performance_logger.cc
index 23d94e91549fc7e2543ad803ae03ac4a04ef345b..d7f61c545c3f325dee386e258b458a94b61a6b16 100644
--- a/chrome/test/chromedriver/performance_logger.cc
+++ b/chrome/test/chromedriver/performance_logger.cc
@@ -190,8 +190,8 @@
"received DevTools trace data in unexpected format");
}
for (const auto& trace : *traces) {
- const base::DictionaryValue* event_dict;
- if (!trace.GetAsDictionary(&event_dict))
+ base::DictionaryValue* event_dict;
+ if (!trace->GetAsDictionary(&event_dict))
return Status(kUnknownError, "trace event must be a dictionary");
AddLogEntry(client->GetId(), "Tracing.dataCollected", *event_dict);
}
« no previous file with comments | « chrome/test/chromedriver/logging.cc ('k') | chrome/utility/importer/nss_decryptor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698