Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3174)

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc
diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc
index 626c2433cf3d3d99ad5d0f69ded14294f851a8ca..53edf362b7f66b73f787a68ab16e7e4e9e6dc22c 100644
--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc
+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc
@@ -235,7 +235,7 @@
for (base::ListValue::const_iterator it = value_as_list->begin();
it != value_as_list->end(); ++it) {
std::string content_type;
- if (!it->GetAsString(&content_type)) {
+ if (!(*it)->GetAsString(&content_type)) {
*error = ErrorUtils::FormatErrorMessage(kInvalidValue, name);
return scoped_refptr<const WebRequestConditionAttribute>(NULL);
}
@@ -384,7 +384,7 @@
for (base::ListValue::const_iterator it = tests->begin();
it != tests->end(); ++it) {
const base::DictionaryValue* tests = NULL;
- if (!it->GetAsDictionary(&tests))
+ if (!(*it)->GetAsDictionary(&tests))
return std::unique_ptr<const HeaderMatcher>();
std::unique_ptr<const HeaderMatchTest> header_test(
@@ -509,7 +509,7 @@
const base::ListValue* list = NULL;
CHECK(content->GetAsList(&list));
for (const auto& it : *list) {
- tests->push_back(StringMatchTest::Create(it, match_type, !is_name));
+ tests->push_back(StringMatchTest::Create(*it, match_type, !is_name));
}
break;
}
@@ -810,7 +810,7 @@
std::string stage_name;
for (base::ListValue::const_iterator it = list->begin();
it != list->end(); ++it) {
- if (!(it->GetAsString(&stage_name)))
+ if (!((*it)->GetAsString(&stage_name)))
return false;
if (stage_name == keys::kOnBeforeRequestEnum) {
stages |= ON_BEFORE_REQUEST;
« no previous file with comments | « extensions/browser/api/declarative/declarative_api.cc ('k') | extensions/browser/api/device_permissions_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698