ui/app_list/search/history_data_store.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/search/history_data_store.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/app_list/search/history_data_store.cc

diff --git a/ui/app_list/search/history_data_store.cc b/ui/app_list/search/history_data_store.cc

index d080fa6a96381ff65c83298d6cc7209ca3d76d0f..1eb92b0d207a8d9871a4c4ae752ecc789b5908cc 100644

--- a/ui/app_list/search/history_data_store.cc

+++ b/ui/app_list/search/history_data_store.cc

@@ -35,7 +35,7 @@

for (base::ListValue::const_iterator it = list->begin(); it != list->end();

++it) {

std::string str;

- if (!it->GetAsString(&str))

+ if (!(*it)->GetAsString(&str))

return;

results.push_back(str);

« no previous file with comments | « tools/json_schema_compiler/util.h ('k') | ui/display/manager/json_converter.cc » ('j') | no next file with comments »