chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc ('k') | chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

diff --git a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

index b32a2954c071fefb40f6ae998a4ed5a7ffb4ec06..0938b0d2df1e98e429ea4e7ada4f1bf285b0af0a 100644

--- a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

+++ b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

@@ -763,7 +763,7 @@

for (auto it2 = list_value->begin(); it2 != list_value->end(); ++it2) {

// Try to read as dictionary.

const base::DictionaryValue *dict_value;

- if (it2->GetAsDictionary(&dict_value)) {

+ if ((*it2)->GetAsDictionary(&dict_value)) {

if (dict_value->size() != 1) {

LOG(ERROR) << extension->id()

<< " has dict in permission list with size "

@@ -785,7 +785,7 @@

}

// Try to read as string.

std::string permission_string;

- if (!it2->GetAsString(&permission_string)) {

+ if (!(*it2)->GetAsString(&permission_string)) {

LOG(ERROR) << extension->id() << ": " << it.key()

<< " contains a token that's neither a string nor a dict.";

safe = false;