Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: ios/chrome/browser/autofill/autofill_agent.mm

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/public/internal/value_conversions.h ('k') | ios/web/web_state/ui/crw_web_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/autofill/autofill_agent.mm
diff --git a/ios/chrome/browser/autofill/autofill_agent.mm b/ios/chrome/browser/autofill/autofill_agent.mm
index 651542f4bf5261dc4587bb8f8a36ab2918170c06..db8e6ab11986afa49153eaa491ad578c92d70a56 100644
--- a/ios/chrome/browser/autofill/autofill_agent.mm
+++ b/ios/chrome/browser/autofill/autofill_agent.mm
@@ -267,7 +267,7 @@
if (field.GetList("option_values", &optionValues)) {
for (const auto& optionValue : *optionValues) {
base::string16 value;
- if (optionValue.GetAsString(&value))
+ if (optionValue->GetAsString(&value))
fieldData->option_values.push_back(value);
}
}
@@ -277,7 +277,7 @@
if (field.GetList("option_contents", &optionContents)) {
for (const auto& optionContent : *optionContents) {
base::string16 content;
- if (optionContent.GetAsString(&content))
+ if (optionContent->GetAsString(&content))
fieldData->option_contents.push_back(content);
}
}
@@ -365,7 +365,7 @@
for (const auto& formDict : *formsList) {
// Each form list entry should be a JSON dictionary.
const base::DictionaryValue* formData;
- if (!formDict.GetAsDictionary(&formData))
+ if (!formDict->GetAsDictionary(&formData))
return NO;
// Form data is copied into a FormData object field-by-field.
@@ -404,7 +404,7 @@
for (const auto& fieldDict : *fieldsList) {
const base::DictionaryValue* field;
autofill::FormFieldData fieldData;
- if (fieldDict.GetAsDictionary(&field) &&
+ if (fieldDict->GetAsDictionary(&field) &&
[self extractFormField:*field asFieldData:&fieldData]) {
form.fields.push_back(fieldData);
} else {
« no previous file with comments | « headless/public/internal/value_conversions.h ('k') | ios/web/web_state/ui/crw_web_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698