extensions/common/manifest_handlers/requirements_info.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/requirements_info.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/manifest_handlers/requirements_info.cc

diff --git a/extensions/common/manifest_handlers/requirements_info.cc b/extensions/common/manifest_handlers/requirements_info.cc

index 0acbf7baddc187506faa674d0c5fd7cd082de9cc..d73af89c0902de0c689f704675ed6525e5980fdc 100644

--- a/extensions/common/manifest_handlers/requirements_info.cc

+++ b/extensions/common/manifest_handlers/requirements_info.cc

@@ -117,7 +117,7 @@

for (base::ListValue::const_iterator feature_iter = features->begin();

feature_iter != features->end(); ++feature_iter) {

std::string feature;

- if (feature_iter->GetAsString(&feature)) {

+ if ((*feature_iter)->GetAsString(&feature)) {

if (feature == "webgl") {

requirements->webgl = true;

} else if (feature == "css3d") {