Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/chrome_devtools_manager_delegate.cc
diff --git a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc b/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
index 3939cc6e9144370a39406474ad9b0c02e56a090e..d2008b54831d2afdd9c597ff987ef57e5df4943b 100644
--- a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
+++ b/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
@@ -262,12 +262,12 @@
return DevToolsProtocol::CreateInvalidParamsResponse(command_id,
kLocationsParam);
for (const auto& item : *locations) {
- if (!item.IsType(base::Value::Type::DICTIONARY)) {
+ if (!item->IsType(base::Value::Type::DICTIONARY)) {
return DevToolsProtocol::CreateInvalidParamsResponse(command_id,
kLocationsParam);
}
- const base::DictionaryValue* dictionary =
- static_cast<const base::DictionaryValue*>(&item);
+ base::DictionaryValue* dictionary =
+ static_cast<base::DictionaryValue*>(item.get());
std::string host;
if (!dictionary->GetStringWithoutPathExpansion(kHostParam, &host)) {
return DevToolsProtocol::CreateInvalidParamsResponse(command_id,

Powered by Google App Engine
This is Rietveld 408576698