Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: extensions/browser/api/declarative/declarative_api.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/declarative/declarative_api.cc
diff --git a/extensions/browser/api/declarative/declarative_api.cc b/extensions/browser/api/declarative/declarative_api.cc
index b2393b2c9a375c9b8105b9942482315c60fb85dc..1b7ca1886cfae38dfd2f8c8601f51cc614af25a4 100644
--- a/extensions/browser/api/declarative/declarative_api.cc
+++ b/extensions/browser/api/declarative/declarative_api.cc
@@ -55,17 +55,17 @@
size_t index = 0;
for (base::ListValue::iterator iter = args->begin(); iter != args->end();
++iter, ++index) {
- if (iter->IsType(base::Value::Type::BINARY)) {
+ if ((*iter)->IsType(base::Value::Type::BINARY)) {
base::Value* binary = NULL;
if (args->GetBinary(index, &binary))
args->Set(index, ConvertBinaryToBase64(binary).release());
- } else if (iter->IsType(base::Value::Type::LIST)) {
+ } else if ((*iter)->IsType(base::Value::Type::LIST)) {
base::ListValue* list;
- iter->GetAsList(&list);
+ (*iter)->GetAsList(&list);
ConvertBinaryListElementsToBase64(list);
- } else if (iter->IsType(base::Value::Type::DICTIONARY)) {
+ } else if ((*iter)->IsType(base::Value::Type::DICTIONARY)) {
base::DictionaryValue* dict;
- iter->GetAsDictionary(&dict);
+ (*iter)->GetAsDictionary(&dict);
ConvertBinaryDictionaryValuesToBase64(dict);
}
}
« no previous file with comments | « dbus/values_util.cc ('k') | extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698