extensions/renderer/api_signature.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_signature.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/api_signature.cc

diff --git a/extensions/renderer/api_signature.cc b/extensions/renderer/api_signature.cc

index c83eb9105f367c6b3b877b788ce12cd58a18d81a..683ba1ff388f634a44d08132569a43e5148562e6 100644

--- a/extensions/renderer/api_signature.cc

+++ b/extensions/renderer/api_signature.cc

@@ -234,7 +234,7 @@

signature_.reserve(specification.GetSize());

for (const auto& value : specification) {

const base::DictionaryValue* param = nullptr;

- CHECK(value.GetAsDictionary(&param));

+ CHECK(value->GetAsDictionary(&param));

signature_.push_back(base::MakeUnique<ArgumentSpec>(*param));

}

« no previous file with comments | « extensions/renderer/api_request_handler.cc ('k') | extensions/renderer/argument_spec.cc » ('j') | no next file with comments »