components/translate/core/browser/translate_prefs.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_prefs.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/core/browser/translate_prefs.cc

diff --git a/components/translate/core/browser/translate_prefs.cc b/components/translate/core/browser/translate_prefs.cc

index 63d758b0aa7b2f54b7063ed5fb4c2a702674ec41..6e8f7b6ccfd92f8a9c02dc5a2644a333783ab710 100644

--- a/components/translate/core/browser/translate_prefs.cc

+++ b/components/translate/core/browser/translate_prefs.cc

@@ -616,7 +616,8 @@

const base::DictionaryValue* item = nullptr;

std::string language;

double probability = 0.0;

- if (entry.GetAsDictionary(&item) && item->GetString(kLanguage, &language) &&

+ if (entry->GetAsDictionary(&item) &&

+ item->GetString(kLanguage, &language) &&

item->GetDouble(kProbability, &probability)) {

// Normalize the the language code known and supported by

// Translate.