chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc ('k') | chrome/browser/ui/webui/options/certificate_manager_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc

diff --git a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc

index 8e0263824e73d88dcdc17c300f2c413c9b31c21e..4a0f275b04b5f09372a429d2561d668b87eb564c 100644

--- a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc

+++ b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc

@@ -46,7 +46,7 @@

const base::ListValue* list;

if (value.GetAsList(&list)) {

for (const auto& list_item : *list)

- ids.push_back(GetId(list_item));

+ ids.push_back(GetId(*list_item));

} else {

ids.push_back(GetId(value));

}