Revert of Change base::Value::ListStorage to std::vector<base::Value>

extensions/common/api/declarative/declarative_manifest_data.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/api/declarative/declarative_manifest_data.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/strings/string_piece.h"
@@ skipping 111 matching lines @@
       new DeclarativeManifestData());
   const base::ListValue* list = nullptr;
   if (!value.GetAsList(&list)) {
     error_builder.Append("'event_rules' expected list, got %s",
                          base::Value::GetTypeName(value.GetType()));
     return std::unique_ptr<DeclarativeManifestData>();
   }
 
   for (const auto& element : *list) {
     const base::DictionaryValue* dict = nullptr;
-    if (!element.GetAsDictionary(&dict)) {
+    if (!element->GetAsDictionary(&dict)) {
       error_builder.Append("expected dictionary, got %s",
-                           base::Value::GetTypeName(element.GetType()));
+                           base::Value::GetTypeName(element->GetType()));
       return std::unique_ptr<DeclarativeManifestData>();
     }
     std::string event;
     if (!dict->GetString("event", &event)) {
       error_builder.Append("'event' is required");
       return std::unique_ptr<DeclarativeManifestData>();
     }
 
     linked_ptr<Rule> rule(new Rule());
     if (!Rule::Populate(*dict, rule.get())) {
       error_builder.Append("rule failed to populate");
       return std::unique_ptr<DeclarativeManifestData>();
     }
 
     if (!ConvertManifestRule(rule, &error_builder))
       return std::unique_ptr<DeclarativeManifestData>();
 
     result->event_rules_map_[event].push_back(rule);
   }
   return result;
 }
 
 std::vector<linked_ptr<DeclarativeManifestData::Rule>>&
 DeclarativeManifestData::RulesForEvent(const std::string& event) {
   return event_rules_map_[event];
 }
 
 }  // namespace extensions