dbus/values_util.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dbus/values_util.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dbus/values_util.cc

diff --git a/dbus/values_util.cc b/dbus/values_util.cc

index e57380d1fa7e0b1b3f0987b773ed71707210fc8f..1e035c9cfe9e5ee416e84e0732c90ec2c0369e26 100644

--- a/dbus/values_util.cc

+++ b/dbus/values_util.cc

@@ -282,7 +282,7 @@

dbus::MessageWriter array_writer(NULL);

writer->OpenArray("v", &array_writer);

for (const auto& value : *list) {

- AppendValueDataAsVariant(&array_writer, value);

+ AppendValueDataAsVariant(&array_writer, *value);

}

writer->CloseContainer(&array_writer);

break;