Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: components/autofill/core/browser/autofill_address_util.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_address_util.cc
diff --git a/components/autofill/core/browser/autofill_address_util.cc b/components/autofill/core/browser/autofill_address_util.cc
index c232e0026513379e93b646177282b74d02c7b41f..e0e9b284e94fd18e3ad8c3f1bc9662839209c3a2 100644
--- a/components/autofill/core/browser/autofill_address_util.cc
+++ b/components/autofill/core/browser/autofill_address_util.cc
@@ -76,8 +76,6 @@
components[i].length_hint == AddressUiComponent::HINT_LONG) {
line = new base::ListValue;
address_components->Append(base::WrapUnique(line));
- // |line| is invalidated at this point, so it needs to be reset.
- address_components->GetList(address_components->GetSize() - 1, &line);
}
std::unique_ptr<base::DictionaryValue> component(new base::DictionaryValue);

Powered by Google App Engine
This is Rietveld 408576698