Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chromeos/network/shill_property_handler.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/shill_property_handler.cc
diff --git a/chromeos/network/shill_property_handler.cc b/chromeos/network/shill_property_handler.cc
index 260c35958f80de77cf5d512daa01d85520e4a2a0..74ea70acdb581e8203b4baaecb776813793bc7d1 100644
--- a/chromeos/network/shill_property_handler.cc
+++ b/chromeos/network/shill_property_handler.cc
@@ -365,7 +365,7 @@
for (base::ListValue::const_iterator iter = entries.begin();
iter != entries.end(); ++iter) {
std::string path;
- iter->GetAsString(&path);
+ (*iter)->GetAsString(&path);
if (path.empty())
continue;
@@ -389,7 +389,7 @@
ShillPropertyObserverMap new_observed;
for (const auto& entry : entries) {
std::string path;
- entry.GetAsString(&path);
+ entry->GetAsString(&path);
if (path.empty())
continue;
auto iter = observer_map.find(path);
@@ -422,7 +422,7 @@
for (base::ListValue::const_iterator iter = technologies.begin();
iter != technologies.end(); ++iter) {
std::string technology;
- iter->GetAsString(&technology);
+ (*iter)->GetAsString(&technology);
DCHECK(!technology.empty());
available_technologies_.insert(technology);
}
@@ -436,7 +436,7 @@
for (base::ListValue::const_iterator iter = technologies.begin();
iter != technologies.end(); ++iter) {
std::string technology;
- iter->GetAsString(&technology);
+ (*iter)->GetAsString(&technology);
DCHECK(!technology.empty());
enabled_technologies_.insert(technology);
enabling_technologies_.erase(technology);
@@ -451,7 +451,7 @@
for (base::ListValue::const_iterator iter = technologies.begin();
iter != technologies.end(); ++iter) {
std::string technology;
- iter->GetAsString(&technology);
+ (*iter)->GetAsString(&technology);
DCHECK(!technology.empty());
uninitialized_technologies_.insert(technology);
}
@@ -549,7 +549,7 @@
return;
for (base::ListValue::const_iterator iter = ip_configs->begin();
iter != ip_configs->end(); ++iter) {
- RequestIPConfig(type, path, *iter);
+ RequestIPConfig(type, path, **iter);
}
}
« no previous file with comments | « chromeos/network/prohibited_technologies_handler.cc ('k') | chromeos/network/shill_property_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698