chromeos/network/network_util.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_util.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_util.cc

diff --git a/chromeos/network/network_util.cc b/chromeos/network/network_util.cc

index db4623bf2cbde33ab199badcab673a083ccbb50e..9d08c59fab8cb4ac3dddedced845176cac5aafdf 100644

--- a/chromeos/network/network_util.cc

+++ b/chromeos/network/network_util.cc

@@ -137,7 +137,7 @@

scan_results->reserve(list.GetSize());

for (const auto& value : list) {

const base::DictionaryValue* dict;

- if (!value.GetAsDictionary(&dict))

+ if (!value->GetAsDictionary(&dict))

return false;

CellularScanResult scan_result;

// If the network id property is not present then this network cannot be