Revert of Change base::Value::ListStorage to std::vector<base::Value>

chromeos/network/network_sms_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_sms_handler.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 97 matching lines @@
   DBusThreadManager::Get()->GetGsmSMSClient()->RequestUpdate(
       service_name_, object_path_);
 }
 
 void NetworkSmsHandler::ModemManagerNetworkSmsDeviceHandler::ListCallback(
     const base::ListValue& message_list) {
   // This receives all messages, so clear any pending deletes.
   delete_queue_.clear();
   for (base::ListValue::const_iterator iter = message_list.begin();
        iter != message_list.end(); ++iter) {
-    const base::DictionaryValue* message = NULL;
-    if (iter->GetAsDictionary(&message))
+    base::DictionaryValue* message = NULL;
+    if (!(*iter)->GetAsDictionary(&message))
       continue;
     MessageReceived(*message);
     double index = 0;
     if (message->GetDoubleWithoutPathExpansion(kIndexKey, &index))
       delete_queue_.push_back(static_cast<uint32_t>(index));
   }
   DeleteMessages();
 }
 
 // Messages must be deleted one at a time, since we can not guarantee
@@ skipping 286 matching lines @@
     return;
   }
   const base::ListValue* devices = static_cast<const base::ListValue*>(value);
   UpdateDevices(devices);
 }
 
 void NetworkSmsHandler::UpdateDevices(const base::ListValue* devices) {
   for (base::ListValue::const_iterator iter = devices->begin();
        iter != devices->end(); ++iter) {
     std::string device_path;
-    iter->GetAsString(&device_path);
+    (*iter)->GetAsString(&device_path);
     if (!device_path.empty()) {
       // Request device properties.
       VLOG(1) << "GetDeviceProperties: " << device_path;
       DBusThreadManager::Get()->GetShillDeviceClient()->GetProperties(
           dbus::ObjectPath(device_path),
           base::Bind(&NetworkSmsHandler::DevicePropertiesCallback,
                      weak_ptr_factory_.GetWeakPtr(),
                      device_path));
     }
   }
@@ skipping 37 matching lines @@
         base::MakeUnique<ModemManager1NetworkSmsDeviceHandler>(
             this, service_name, object_path));
   } else {
     device_handlers_.push_back(
         base::MakeUnique<ModemManagerNetworkSmsDeviceHandler>(
             this, service_name, object_path));
   }
 }
 
 }  // namespace chromeos