chrome/browser/ui/app_list/search/webstore/webstore_provider.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

diff --git a/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc b/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

index 7999174d30741ce98d5dee7b20bbbb3f270c40f8..12b0c57595eb5262b5e029944e760b1c5a320bb4 100644

--- a/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

+++ b/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

@@ -139,7 +139,7 @@

it != result_list->end();

++it) {

const base::DictionaryValue* dict;

- if (!it->GetAsDictionary(&dict))

+ if (!(*it)->GetAsDictionary(&dict))

continue;

std::unique_ptr<SearchResult> result(CreateResult(query, *dict));