Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: tools/json_schema_compiler/util.h

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | ui/app_list/search/history_data_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/json_schema_compiler/util.h
diff --git a/tools/json_schema_compiler/util.h b/tools/json_schema_compiler/util.h
index 8d206a6672a4870dd609f4235766ca474bba3e25..d7862cea4f63a6682cbe25aebc8bbe0a67eae08e 100644
--- a/tools/json_schema_compiler/util.h
+++ b/tools/json_schema_compiler/util.h
@@ -102,7 +102,7 @@
out->clear();
T item;
for (const auto& value : list) {
- if (!PopulateItem(value, &item))
+ if (!PopulateItem(*value, &item))
return false;
// T might not be movable, but in that case it should be copyable, and this
// will still work.
@@ -121,7 +121,7 @@
out->clear();
T item;
for (const auto& value : list) {
- if (!PopulateItem(value, &item, error))
+ if (!PopulateItem(*value, &item, error))
return false;
out->push_back(std::move(item));
}
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | ui/app_list/search/history_data_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698