chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc ('k') | chrome/browser/extensions/extension_management.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc

diff --git a/chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc b/chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc

index 8f9410f00a44cea8abc2bb6a214f8bdb8a01d970..bb153dc8f1a8c1523993b4c3fbfb3c99d7559759 100644

--- a/chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc

+++ b/chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc

@@ -68,7 +68,7 @@

for (base::ListValue::const_iterator entry(list_value->begin());

entry != list_value->end(); ++entry) {

std::string name;

- if (!entry->GetAsString(&name)) {

+ if (!(*entry)->GetAsString(&name)) {

errors->AddError(policy_name(), entry - list_value->begin(),

IDS_POLICY_TYPE_ERROR,

base::Value::GetTypeName(base::Value::Type::STRING));