Revert of Change base::Value::ListStorage to std::vector<base::Value>

content/browser/webrtc/webrtc_internals_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/webrtc/webrtc_internals.h"
 
 #include <memory>
 #include <string>
 
 #include "base/message_loop/message_loop.h"
@@ skipping 123 matching lines @@
 
   // Make sure we don't have a log entry since there was no observer.
   MockWebRtcInternalsProxy observer;
   webrtc_internals.UpdateObserver(&observer);
   EXPECT_EQ("updateAllPeerConnections", observer.command());
 
   base::ListValue* list = nullptr;
   ASSERT_TRUE(observer.value()->GetAsList(&list));
   EXPECT_EQ(1U, list->GetSize());
   base::DictionaryValue* dict = nullptr;
-  ASSERT_TRUE((*list->begin()).GetAsDictionary(&dict));
+  ASSERT_TRUE((*list->begin())->GetAsDictionary(&dict));
   base::ListValue* log = nullptr;
   ASSERT_FALSE(dict->GetList("log", &log));
 
   webrtc_internals.OnRemovePeerConnection(3, 4);
 }
 
 TEST_F(WebRtcInternalsTest, EnsureLogIsRemovedWhenObserverIsRemoved) {
   base::RunLoop loop;
   WebRTCInternalsForTest webrtc_internals;
   MockWebRtcInternalsProxy observer;
   webrtc_internals.AddObserver(&observer);
   webrtc_internals.OnAddPeerConnection(0, 3, 4, kUrl, kRtcConfiguration,
                                        kContraints);
   webrtc_internals.OnUpdatePeerConnection(3, 4, "update_type", "update_value");
   BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, loop.QuitClosure());
   loop.Run();
 
   // Make sure we have a log entry since there was an observer.
   webrtc_internals.UpdateObserver(&observer);
   EXPECT_EQ("updateAllPeerConnections", observer.command());
 
   base::ListValue* list = nullptr;
   ASSERT_TRUE(observer.value()->GetAsList(&list));
   EXPECT_EQ(1U, list->GetSize());
   base::DictionaryValue* dict = nullptr;
-  ASSERT_TRUE((*list->begin()).GetAsDictionary(&dict));
+  ASSERT_TRUE((*list->begin())->GetAsDictionary(&dict));
   base::ListValue* log = nullptr;
   ASSERT_TRUE(dict->GetList("log", &log));
 
   // Make sure we the log entry was removed when the last observer was removed.
   webrtc_internals.RemoveObserver(&observer);
   webrtc_internals.UpdateObserver(&observer);
   EXPECT_EQ("updateAllPeerConnections", observer.command());
 
   ASSERT_TRUE(observer.value()->GetAsList(&list));
   EXPECT_EQ(1U, list->GetSize());
-  ASSERT_TRUE((*list->begin()).GetAsDictionary(&dict));
+  ASSERT_TRUE((*list->begin())->GetAsDictionary(&dict));
   ASSERT_FALSE(dict->GetList("log", &log));
 
   webrtc_internals.OnRemovePeerConnection(3, 4);
 }
 
 TEST_F(WebRtcInternalsTest, SendAddPeerConnectionUpdate) {
   base::RunLoop loop;
   MockWebRtcInternalsProxy observer(&loop);
   WebRTCInternalsForTest webrtc_internals;
   webrtc_internals.AddObserver(&observer);
@@ skipping 133 matching lines @@
   webrtc_internals.UpdateObserver(&observer);
 
   EXPECT_EQ("updateAllPeerConnections", observer.command());
   ASSERT_TRUE(observer.value());
 
   base::ListValue* list = NULL;
   EXPECT_TRUE(observer.value()->GetAsList(&list));
   EXPECT_EQ(1U, list->GetSize());
 
   base::DictionaryValue* dict = NULL;
-  EXPECT_TRUE((*list->begin()).GetAsDictionary(&dict));
+  EXPECT_TRUE((*list->begin())->GetAsDictionary(&dict));
 
   VerifyInt(dict, "rid", rid);
   VerifyInt(dict, "pid", pid);
   VerifyInt(dict, "lid", lid);
   VerifyString(dict, "url", kUrl);
   VerifyString(dict, "rtcConfiguration", kRtcConfiguration);
   VerifyString(dict, "constraints", kContraints);
 
   base::ListValue* log = NULL;
   ASSERT_TRUE(dict->GetList("log", &log));
   EXPECT_EQ(1U, log->GetSize());
 
-  EXPECT_TRUE((*log->begin()).GetAsDictionary(&dict));
+  EXPECT_TRUE((*log->begin())->GetAsDictionary(&dict));
   VerifyString(dict, "type", update_type);
   VerifyString(dict, "value", update_value);
   std::string time;
   EXPECT_TRUE(dict->GetString("time", &time));
   EXPECT_FALSE(time.empty());
 }
 
 TEST_F(WebRtcInternalsTest, OnAddStats) {
   const int rid = 0, pid = 1, lid = 2;
   base::RunLoop loop;
@@ skipping 79 matching lines @@
   webrtc_internals.OnRemovePeerConnection(pid, lid[1]);
   EXPECT_EQ(0, webrtc_internals.num_open_connections());
   EXPECT_FALSE(webrtc_internals.IsPowerSavingBlocked());
 
   webrtc_internals.OnRemovePeerConnection(pid, lid[0]);
   EXPECT_EQ(0, webrtc_internals.num_open_connections());
   EXPECT_FALSE(webrtc_internals.IsPowerSavingBlocked());
 }
 
 }  // namespace content