Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Also eliminates use of mojo::shell::mojom::Shell in favor of this base interface.

This means most code doesn't have to use ApplicationImpl - only the places that instantiate them.

TBR=rockot@chromium.org
BUG=

Committed: https://crrev.com/3a7cbe0bed9f9b81ab1da4ed0e4dba764345977e
Cr-Commit-Position: refs/heads/master@{#374049}

[Ben Goodger (Google), 2016-02-06 18:12:26]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-06 18:12:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674903003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674903003/100001

[Ben Goodger (Google), 2016-02-06 18:22:14]

Description was changed from

==========
Extract shell methods from ApplicationImpl into a base class, and pass this to
Initialize() instead.

BUG=
==========

to

==========
Extract shell methods from ApplicationImpl into a base class, and pass this to
Initialize() instead.

Also eliminates use of mojo::shell::mojom::Shell in favor of this base
interface.

This means most code doesn't have to use ApplicationImpl - only the places that
instantiate them.

TBR=rockot@chromium.org
BUG=
==========

[Ben Goodger (Google), 2016-02-06 18:22:15]

ben@chromium.org changed reviewers:
+ rockot@chromium.org

[commit-bot: I haz the power, 2016-02-06 18:28:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-06 18:28:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-02-06 18:37:17]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-06 18:37:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674903003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674903003/120001

[commit-bot: I haz the power, 2016-02-06 18:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-06 18:49:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-02-06 19:02:49]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-06 19:03:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674903003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674903003/140001

[Ken Rockot(use gerrit already), 2016-02-06 19:19:48]

great, lgtm

[commit-bot: I haz the power, 2016-02-06 19:24:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-06 19:24:16]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Ben Goodger (Google), 2016-02-06 19:35:05]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-06 19:35:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674903003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674903003/160001

[Ben Goodger (Google), 2016-02-06 21:00:26]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-06 21:00:27]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1674903003/#ps160001
(title: ".")

[commit-bot: I haz the power, 2016-02-06 21:00:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674903003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674903003/160001

[commit-bot: I haz the power, 2016-02-07 04:35:38]

Description was changed from

==========
Extract shell methods from ApplicationImpl into a base class, and pass this to
Initialize() instead.

Also eliminates use of mojo::shell::mojom::Shell in favor of this base
interface.

This means most code doesn't have to use ApplicationImpl - only the places that
instantiate them.

TBR=rockot@chromium.org
BUG=
==========

to

==========
Extract shell methods from ApplicationImpl into a base class, and pass this to
Initialize() instead.

Also eliminates use of mojo::shell::mojom::Shell in favor of this base
interface.

This means most code doesn't have to use ApplicationImpl - only the places that
instantiate them.

TBR=rockot@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-02-07 04:35:40]

Committed patchset #10 (id:160001)

[commit-bot: I haz the power, 2016-02-07 04:36:57]

Description was changed from

==========
Extract shell methods from ApplicationImpl into a base class, and pass this to
Initialize() instead.

Also eliminates use of mojo::shell::mojom::Shell in favor of this base
interface.

This means most code doesn't have to use ApplicationImpl - only the places that
instantiate them.

TBR=rockot@chromium.org
BUG=
==========

to

==========
Extract shell methods from ApplicationImpl into a base class, and pass this to
Initialize() instead.

Also eliminates use of mojo::shell::mojom::Shell in favor of this base
interface.

This means most code doesn't have to use ApplicationImpl - only the places that
instantiate them.

TBR=rockot@chromium.org
BUG=

Committed: https://crrev.com/3a7cbe0bed9f9b81ab1da4ed0e4dba764345977e
Cr-Commit-Position: refs/heads/master@{#374049}
==========

[commit-bot: I haz the power, 2016-02-07 04:36:58]

Patchset 10 (id:??) landed as
https://crrev.com/3a7cbe0bed9f9b81ab1da4ed0e4dba764345977e
Cr-Commit-Position: refs/heads/master@{#374049}