mojo/services/network/udp_socket_apptest.cc - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/network/udp_socket_apptest.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/services/network/network_service_delegate.cc ('k') | mojo/services/test_service/test_request_tracker_application.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/network/udp_socket_apptest.cc

diff --git a/mojo/services/network/udp_socket_apptest.cc b/mojo/services/network/udp_socket_apptest.cc

index 66e0a127ba7340f78eb16ab198c1ca3df91b433e..da1634dfb4072d416233ef6b002a427293d341d7 100644

--- a/mojo/services/network/udp_socket_apptest.cc

+++ b/mojo/services/network/udp_socket_apptest.cc

@@ -15,7 +15,6 @@

#include "mojo/services/network/public/interfaces/network_service.mojom.h"

#include "mojo/services/network/public/interfaces/udp_socket.mojom.h"

#include "mojo/shell/public/cpp/application_connection.h"

-#include "mojo/shell/public/cpp/application_impl.h"

#include "mojo/shell/public/cpp/application_test_base.h"

#include "net/base/net_errors.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -326,8 +325,7 @@ class UDPSocketAppTest : public test::ApplicationTestBase {

void SetUp() override {

ApplicationTestBase::SetUp();

- application_impl()->ConnectToService("mojo:network_service",

- &network_service_);

+ shell()->ConnectToService("mojo:network_service", &network_service_);

network_service_->CreateUDPSocket(GetProxy(&socket_));

}

« no previous file with comments | « mojo/services/network/network_service_delegate.cc ('k') | mojo/services/test_service/test_request_tracker_application.h » ('j') | no next file with comments »