components/resource_provider/resource_provider_app.cc - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/resource_provider/resource_provider_app.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/resource_provider/resource_provider_app.h ('k') | components/resource_provider/resource_provider_apptest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/resource_provider/resource_provider_app.cc

diff --git a/components/resource_provider/resource_provider_app.cc b/components/resource_provider/resource_provider_app.cc

index f3e0ba5046c3e89d6929a0248e5c143cade64737..79e034d1f7eca465eb6f237e6fe8ff0d2d9e8ba3 100644

--- a/components/resource_provider/resource_provider_app.cc

+++ b/components/resource_provider/resource_provider_app.cc

@@ -21,8 +21,9 @@ ResourceProviderApp::ResourceProviderApp(

ResourceProviderApp::~ResourceProviderApp() {

}

-void ResourceProviderApp::Initialize(mojo::ApplicationImpl* app) {

- tracing_.Initialize(app);

+void ResourceProviderApp::Initialize(mojo::Shell* shell, const std::string& url,

+ uint32_t id) {

+ tracing_.Initialize(shell, url);

}

bool ResourceProviderApp::AcceptConnection(

« no previous file with comments | « components/resource_provider/resource_provider_app.h ('k') | components/resource_provider/resource_provider_apptest.cc » ('j') | no next file with comments »