sql/mojo/sql_test_base.cc - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sql/mojo/sql_test_base.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sql/mojo/sql_test_base.cc

diff --git a/sql/mojo/sql_test_base.cc b/sql/mojo/sql_test_base.cc

index 3086007dac2764cb36b32e11bad0b96139d51879..ab37af25eaa44b27e50ef3df8eee0f5eab1f0a52 100644

--- a/sql/mojo/sql_test_base.cc

+++ b/sql/mojo/sql_test_base.cc

@@ -8,7 +8,7 @@

#include <stdint.h>

#include <utility>

-#include "mojo/shell/public/cpp/application_impl.h"

+#include "mojo/shell/public/cpp/shell.h"

#include "mojo/util/capture_util.h"

#include "sql/mojo/mojo_vfs.h"

#include "sql/test/test_helpers.h"

@@ -137,7 +137,7 @@ void SQLTestBase::TruncateDatabase() {

void SQLTestBase::SetUp() {

ApplicationTestBase::SetUp();

- application_impl()->ConnectToService("mojo:filesystem", &files_);

+ shell()->ConnectToService("mojo:filesystem", &files_);

filesystem::FileError error = filesystem::FileError::FAILED;

filesystem::DirectoryPtr directory;

« no previous file with comments | « mojo/shell/standalone/test/pingable_app.cc ('k') | sql/mojo/vfs_unittest.cc » ('j') | no next file with comments »