Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: components/html_viewer/global_state.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/html_viewer/content_handler_impl.cc ('k') | components/html_viewer/global_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/html_viewer/global_state.h
diff --git a/components/html_viewer/global_state.h b/components/html_viewer/global_state.h
index 73b3e7a17851e79cac6f035f83eaeee516a72285..1017db753e1639bfc0b3e1e04f8d732117ca69ec 100644
--- a/components/html_viewer/global_state.h
+++ b/components/html_viewer/global_state.h
@@ -24,13 +24,8 @@ class FontLoader;
}
namespace mojo {
-class ApplicationImpl;
-namespace shell {
-namespace mojom {
class Shell;
}
-}
-}
namespace ui {
namespace mojo {
@@ -57,7 +52,7 @@ class MediaFactory;
// . with a ui: this is done via InitIfNecessary().
class GlobalState {
public:
- explicit GlobalState(mojo::ApplicationImpl* app);
+ GlobalState(mojo::Shell* shell, const std::string& url);
~GlobalState();
// Inits with the specified screen size and device pixel ratio.
@@ -102,7 +97,7 @@ class GlobalState {
// App for HTMLViewer, not the document's app.
// WARNING: do not expose this. It's too easy to use the wrong one.
// HTMLDocument should be using the application it creates, not this one.
- mojo::ApplicationImpl* app_;
+ mojo::Shell* shell_;
resource_provider::ResourceLoader resource_loader_;
« no previous file with comments | « components/html_viewer/content_handler_impl.cc ('k') | components/html_viewer/global_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698