mojo/shell/runner/child/native_apptest.cc - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/runner/child/native_apptest.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/shell/runner/child/native_apptest.cc

diff --git a/mojo/shell/runner/child/native_apptest.cc b/mojo/shell/runner/child/native_apptest.cc

index d15498c26ff0f4abb5bdc449c13b77164086f56d..837f2e0c470e9488ad7636502cc06003d59102ea 100644

--- a/mojo/shell/runner/child/native_apptest.cc

+++ b/mojo/shell/runner/child/native_apptest.cc

@@ -5,7 +5,6 @@

#include "base/bind.h"

#include "base/macros.h"

#include "mojo/converters/network/network_type_converters.h"

-#include "mojo/shell/public/cpp/application_impl.h"

#include "mojo/shell/public/cpp/application_test_base.h"

#include "mojo/shell/runner/child/test_native_service.mojom.h"

@@ -21,8 +20,8 @@ using NativeAppTest = mojo::test::ApplicationTestBase;

TEST_F(NativeAppTest, Connect) {

test::TestNativeServicePtr native_service;

- application_impl()->ConnectToService(

- "exe:mojo_runner_child_apptest_native_target", &native_service);

+ shell()->ConnectToService("exe:mojo_runner_child_apptest_native_target",

+ &native_service);

bool result = false;

native_service->Invert(

« no previous file with comments | « mojo/shell/public/cpp/shell.h ('k') | mojo/shell/runner/child/native_apptest_target.cc » ('j') | no next file with comments »